Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled buttons in the image toolbar. #9213

Closed
magda-chrzescian opened this issue Mar 11, 2021 · 2 comments · Fixed by #9459
Closed

Disabled buttons in the image toolbar. #9213

magda-chrzescian opened this issue Mar 11, 2021 · 2 comments · Fixed by #9459
Assignees
@magda-chrzescian
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:core Issue to be handled by the Core team.
Milestone
iteration 43 (v28...

Comments

@magda-chrzescian
Copy link
Contributor

After resolving the #9136, the image toolbar remains visible when the selection is placed inside the image caption. Still, all the buttons (except the caption button) in the toolbar are disabled.

It makes sense to enable the commands bound to these buttons to make the toolbar fully functional.
@magda-chrzescian magda-chrzescian added package:image domain:ui/ux This issue reports a problem related to UI or UX. labels Mar 11, 2021
@magda-chrzescian magda-chrzescian mentioned this issue Mar 11, 2021
Closed
@oleq oleq added the squad:core Issue to be handled by the Core team. label Mar 23, 2021
@oleq oleq mentioned this issue Mar 23, 2021
Closed
@oleq
Copy link
Member

oleq commented Mar 23, 2021

This is a must-have. I already found myself trying to change style after toggling the caption so many times but I couldn't because of this.

@magda-chrzescian magda-chrzescian self-assigned this Apr 12, 2021
@magda-chrzescian magda-chrzescian added this to the iteration 42 milestone Apr 12, 2021
@magda-chrzescian magda-chrzescian mentioned this issue Apr 13, 2021
Merged
@magda-chrzescian magda-chrzescian linked a pull request Apr 13, 2021 that will close this issue
I/9213 enabling caption toolbar #9459
Merged
oleq added a commit that referenced this issue Apr 20, 2021
@oleq
Merge pull request #9459 from ckeditor/i/9213-enabling-caption-toolbar
b6bb0c8 
Fix (image): The buttons in the image toolbar should be enabled when the selection is in a caption. Closes #9213.
Fix (image): Dropdowns in the image toolbar should be disabled when all of the nested buttons are disabled. See #9213.
@oleq
Copy link
Member

oleq commented Apr 20, 2021

Closed in #9459.

@oleq oleq closed this as completed Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magda-chrzescian magda-chrzescian

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:core Issue to be handled by the Core team.
Projects
None yet
Milestone
iteration 43 (v28.0.0)
Development

Successfully merging a pull request may close this issue.

I/9213 enabling caption toolbar ckeditor/ckeditor5
3 participants
@AnnaTomanek @oleq @magda-chrzescian