Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table MouseSelectionHandler should reset its #isSelecting flag on mouseup #6353

Closed
oleq opened this issue Feb 28, 2020 · 1 comment
Closed

Table MouseSelectionHandler should reset its #isSelecting flag on mouseup #6353

oleq opened this issue Feb 28, 2020 · 1 comment
Assignees
@oleq
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 30 (v18...

Comments

@oleq
Copy link
Member

oleq commented Feb 28, 2020

📝 Provide detailed reproduction steps (if any)

It sets the flag true but never false during its lifecycle.

This could potentially affect the selection logic.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. package:table labels Feb 28, 2020
@Reinmar Reinmar mentioned this issue Feb 28, 2020
Closed
21 tasks
@jodator jodator mentioned this issue Feb 28, 2020
Closed
@oleq oleq self-assigned this Feb 28, 2020
@oleq oleq added this to the iteration 30 milestone Feb 28, 2020
@oleq oleq mentioned this issue Feb 28, 2020
Merged
@jodator jodator mentioned this issue Feb 28, 2020
Closed
2 tasks
Reinmar added a commit to ckeditor/ckeditor5-table that referenced this issue Feb 28, 2020
@Reinmar
Merge pull request #257 from ckeditor/i/6114
516ba8c 
Internal: Improved the look of multi-cell selection. Prevented the selection from starting in the fake selection container. Closes ckeditor/ckeditor5#6114. Closes ckeditor/ckeditor5#6353.
@Reinmar Reinmar closed this as completed Feb 28, 2020
@Reinmar
Copy link
Member

Reinmar commented Feb 28, 2020

Closed with ckeditor/ckeditor5-table@516ba8c.

Reinmar added a commit to ckeditor/ckeditor5-table that referenced this issue Feb 28, 2020
@Reinmar
Merge branch 'i/6114'
c9326ee 
Internal: Improved the look of multi-cell selection. Prevented the selection from starting in the fake selection container. Closes ckeditor/ckeditor5#6114. Closes ckeditor/ckeditor5#6353.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 30 (v18.0.0)
Development

No branches or pull requests
2 participants
@Reinmar @oleq