Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppeteer reports a weird warning #14063

Closed
pomek opened this issue May 8, 2023 · 6 comments
Closed

Puppeteer reports a weird warning #14063

pomek opened this issue May 8, 2023 · 6 comments
Assignees
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@pomek
Copy link
Member

pomek commented May 8, 2023

📝 Provide detailed reproduction steps (if any)

  1. yarn run docs
  2. yarn run docs:serve
  3. In a new tab: yarn run docs:verify

✔️ Expected result

No errors, or warnings. The process should check if the documentation is built correctly.

❌ Actual result

  Puppeteer old Headless deprecation warning:
    In the near feature `headless: true` will default to the new Headless mode
    for Chrome instead of the old Headless implementation. For more
    information, please see https://developer.chrome.com/articles/new-headless/.
    Consider opting in early by passing `headless: "new"` to `puppeteer.launch()`
    If you encounter any bugs, please report them to https://github.com/puppeteer/puppeteer/issues/new/choose.
🔥 The following errors have been found:

 RESPONSE FAILURE   ➜  1 error

  ❌ Failed to load resource from fake.ckeditor.com:8080 (HTTP response status code: 404)

    …found on the following pages:
    ➥  http://fake.ckeditor.com:8080/ckeditor5/latest/
    ➥  http://fake.ckeditor.com:8080/ckeditor5/latest/examples/index.html
    ➥  http://fake.ckeditor.com:8080/ckeditor5/latest/installation/index.html
@pomek pomek added type:bug This issue reports a buggy (incorrect) behavior. squad:platform Issue to be handled by the Platform team. package:dev labels May 8, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label May 8, 2023
@przemyslaw-zan przemyslaw-zan self-assigned this May 8, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels May 8, 2023
@przemyslaw-zan
Copy link
Member

The error

Initially I've got the same 404 response from fake.ckeditor.com error after launching the crawler. However, when I've adjusted my hosts file as our docs suggest, the crawler passed entire documentation successfully, without any errors. This seems weird, as this script worked for me previously despite the fact that I've never configured my hosts file before.

Regardless, current behavior looks correct, and I was not able to reproduce the exact error described in the ticket.


The warning

Puppeteer will be migrating to new implementation of headless Chrome in the near future.

We can test this right now by passing headless: 'new' to browserOptions object. Unfortunately, this does not work out of the box, and this line throws this error:

ProtocolError: Protocol error (Target.createTarget): Failed to open a new tab

More research is needed into the topic of migration.

The chrome.com article mentions:

As part of this removal, we’ll make the old Headless available as a separate standalone binary for those users who can’t upgrade yet.

So in case that we are not able to migrate, there will be alternatives for us.

As a temporary measure, we can pass headless: 'old' to browserOptions object to disable the warning.

@pomek
Copy link
Member Author

pomek commented May 9, 2023

Let's hide this warning and switch to the new headless browser in the future (as it requires upgrading Puppeteer too).

przemyslaw-zan added a commit to ckeditor/ckeditor5-dev that referenced this issue May 10, 2023
Other (web-crawler): Puppeteer no longer prints a warning regarding the Chrome Headless browser. See ckeditor/ckeditor5#14063.
@przemyslaw-zan
Copy link
Member

@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 10, 2023
@pomek pomek added this to the iteration 63 milestone May 11, 2023
@Iano-theDev
Copy link

I had this issue while runnig puppeteer on WSL... I thought the issue was wsl but after installing node for windows I got the same issue!

@aynjel
Copy link

aynjel commented Aug 20, 2023

how to fix this issue?

@Witoso
Copy link
Member

Witoso commented Aug 21, 2023

@aynjel unless you have this error in relation to CKEditor 5, we cannot offer much help here. We solved on our side with a:

As a temporary measure, we can pass headless: 'old' to browserOptions object to disable the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

6 participants