Skip to content

Commit

Permalink
Updated code comment.
Browse files Browse the repository at this point in the history
  • Loading branch information
niegowski committed May 5, 2021
1 parent 220232a commit aa5c6b4
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions packages/ckeditor5-engine/src/conversion/downcasthelpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -953,11 +953,13 @@ function handleMarkerBoundary( range, isStart, conversionApi, data, viewMarkerDa

// If possible, we want to add `data-group-start-before` and `data-group-end-after` attributes.
if ( isStart && elementAfter || !isStart && !elementBefore ) {
// `data-group-start-before`, `data-group-end-after`.
// <elementBefore/>[<elementAfter/> -> data-group-start-before elementAfter

This comment has been minimized.

Copy link
@scofalik

scofalik May 5, 2021

Contributor

Umm, I don't like those changes :(, they are a bit confusing, especially those with text.

It should rather be:

[<elementAfter>...</elementAfter> -> data-group-start-before
<parent>]<elementAfter> -> data-group-end-before
<elementBefore>...</elementBefore>] -> data-group-end-after
</elementBefore>[</parent> -> data-group-start-after
// <$text/>]<elementAfter/> -> data-group-end-before elementAfter
modelElement = elementAfter;
isBefore = true;
} else {
// `data-group-end-before`, `data-group-start-after`.
// <elementBefore>[<$text/> -> data-group-start-after elementBefore
// <elementBefore/>]<elementAfter/> -> data-group-end-after elementBefore
modelElement = elementBefore;
isBefore = false;
}
Expand Down

0 comments on commit aa5c6b4

Please sign in to comment.