Force fully unpin tooltip before pin due to memleak issues in tests. (#…

…16103) Internal (ui): Force fully unpin tooltip before pin due to memory leak issues in tests.
ckeditor · Mar 26, 2024 · 11172e2 · 11172e2
1 parent 90aeb27
commit 11172e2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/ckeditor5-ui/src/tooltipmanager.ts b/packages/ckeditor5-ui/src/tooltipmanager.ts
@@ -391,7 +391,7 @@ export default class TooltipManager extends DomEmitterMixin() {
 		targetDomElement: HTMLElement,
 		{ text, position, cssClass }: TooltipData
 	): void {
-		this._unpinTooltipDebounced.cancel();
+		this._unpinTooltip();
 
 		// Use the body collection of the first editor.
 		const bodyViewCollection = first( TooltipManager._editors.values() )!.ui.view.body;
@@ -447,6 +447,7 @@ export default class TooltipManager extends DomEmitterMixin() {
 
 		this._currentElementWithTooltip = null;
 		this._currentTooltipPosition = null;
+		this.tooltipTextView.text = '';
 
 		if ( this._resizeObserver ) {
 			this._resizeObserver.destroy();

diff --git a/packages/ckeditor5-ui/tests/tooltip/tooltipmanager.js b/packages/ckeditor5-ui/tests/tooltip/tooltipmanager.js
@@ -749,7 +749,7 @@ describe( 'TooltipManager', () => {
 				sinon.assert.calledOnce( unpinSpy );
 
 				utils.waitForTheTooltipToHide( clock );
-				sinon.assert.calledTwice( unpinSpy );
+				sinon.assert.calledThrice( unpinSpy );
 			} );
 		} );