This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Added Simple Upload Adapter #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do we do about https://ckeditor.com/docs/ckeditor5/latest/framework/guides/deep-dive/upload-adapter.html in this situation? It feels like it needs a solid refactoring. |
oleq
suggested changes
Jun 25, 2019
|
@oleq, could you review it again? I extended API page and the SImple upload adapter guide. I guess, all your notes have been introduced. |
|
If this PR won't be merged in the current iteration (i25), changes in this PR are BC. |
…necessary information from the upload progress section.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Introduced
SimpleUploadAdapterplugin which enables file uploads in CKEditor 5 using the external side-server connection. Closes ckeditor/ckeditor5#1791.BREAKING CHANGE: Moved the
Base64UploadAdapterplugin tockeditor5-upload/src/adapters/base64uploadadapter.js.