This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/ckeditor5-table/28: Made the ContextualBalloon always use the position of the topmost view in the stack #406
+7
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ost view in the stack (see: ckeditor/ckeditor5-table#28).
oleq
added a commit
to ckeditor/ckeditor5-image
that referenced
this pull request
Jun 8, 2018
…ualBalloon plugin (see ckeditor/ckeditor5-ui#406).
oskarwrobel
pushed a commit
to ckeditor/ckeditor5-image
that referenced
this pull request
Jun 26, 2018
…ualBalloon plugin (see ckeditor/ckeditor5-ui#406).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Made the
ContextualBalloonalways use the position of the topmost view in the stack (see: ckeditor/ckeditor5#3180). Closes ckeditor/ckeditor5#900.Additional information
Note: This will change the behavior of the balloons when one should use the position of another. Check out http://localhost:8125/ckeditor5-ui/tests/manual/contextualballoon/contextualballoon.html to see the difference.
I had to disable this feature because it attached the link balloon to the table instead of an actual link in the content. Generally speaking, the feature was broken in the first place and never had a chance to work properly as the number of use cases (balloons) increased.
So this is more a temp workaround sacrificing a very particular behaviour (BalloonToolbar<->LinkUI) to fix a very annoying bug somwhere else (in tables). The right solution will come in ckeditor/ckeditor5#852.