Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic editor's editable should have a background #3384

Closed
Reinmar opened this issue Oct 3, 2017 · 4 comments · Fixed by ckeditor/ckeditor5-theme-lark#127
Closed

Classic editor's editable should have a background #3384

Reinmar opened this issue Oct 3, 2017 · 4 comments · Fixed by ckeditor/ckeditor5-theme-lark#127
Assignees

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 3, 2017

image

It seems that it's not set by the theme.

@oleq
Copy link
Member

oleq commented Feb 5, 2018

Is this one a content style too? 🤔

@Reinmar
Copy link
Member Author

Reinmar commented Feb 5, 2018

Hm... I'd go with "no". Content is rendered in some place. But this place's styles are not "content"... At least that's how we can explain this :P

@oleq
Copy link
Member

oleq commented Feb 5, 2018

What would it look like in the case of the (pure) inline editable then? Should we style it or not? I'd rather restrict the bg to the classic editor because the editable it creates is a new UI. The inline editor borrows an existing DOM element.

@Reinmar
Copy link
Member Author

Reinmar commented Feb 5, 2018

I'd rather restrict the bg to the classic editor because the editable it creates is a new UI. The inline editor borrows an existing DOM element.

👍

@oleq oleq changed the title Editable's background Classic editor's editable should have a background Feb 5, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-theme-lark Feb 6, 2018
Fix: Classic editor's editable should have a background. Closes #113.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-theme-lark Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants