Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content styles should not be in the theme and should not depend on variables #3387

Closed
Reinmar opened this issue Dec 19, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-theme-lark#128
Assignees

Comments

@Reinmar
Copy link
Member

Reinmar commented Dec 19, 2017

Examples:

  • image styles
  • <code> styles
  • ...

These should be in their respective packages and should not depend on CSS variables.

@oleq
Copy link
Member

oleq commented Dec 20, 2017

I remember that we also discussed how to separate content styles and UI styles. Because if we moved the image, code, etc. styles to their respective packages, still they will be tied to the editor (e.g. loaded by some ImageUI or whatever), which is not alright because developers should be able to:

  1. use them in the frontend where the editor is not loaded,
  2. drop them completely (for whatever the reason).

I'm wondering how to do that and if webpack can help us. What we could possibly do is another entry point JS which would load content styles only using the style-loader. Could that work? OTOH, that would require another <script> tag to insert CKEditor and could cause problems for the people including CKEditor in their applications. This problem looks tricky.

@Reinmar
Copy link
Member Author

Reinmar commented Dec 20, 2017

This is a separate issue. The ability to retrieve all content styles from the editor still requires these styles to be defined in the right place and to be independent of the theme.

So, let's first fix the problem with where these styles are and how they look (which we can do pretty quickly). And then we can start thinking whether we are able to expose content styles in any way (which will be rather hard and we may end up writing them down in the docs manually).

@Reinmar
Copy link
Member Author

Reinmar commented Dec 20, 2017

BTW, widget styles (focus outline, selection border) are not content styles to me. They are part of the editor's UI.

oleq referenced this issue in ckeditor/ckeditor5-basic-styles Feb 6, 2018
oleq referenced this issue in ckeditor/ckeditor5-block-quote Feb 6, 2018
oleq referenced this issue in ckeditor/ckeditor5-image Feb 6, 2018
oleq referenced this issue in ckeditor/ckeditor5-heading Feb 6, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-basic-styles Feb 6, 2018
Internal: Added content styles (moved from the theme package were they landed by mistake). See ckeditor/ckeditor5-theme-lark#119.
Reinmar referenced this issue in ckeditor/ckeditor5-block-quote Feb 6, 2018
Internal: Added content styles (moved from the theme package were they landed by mistake). See ckeditor/ckeditor5-theme-lark#119.
Reinmar referenced this issue in ckeditor/ckeditor5-heading Feb 6, 2018
Internal: Added content styles (moved from the theme package were they landed by mistake). See ckeditor/ckeditor5-theme-lark#119.
Reinmar referenced this issue in ckeditor/ckeditor5-image Feb 6, 2018
Internal: Added content styles (moved from the theme package were they landed by mistake). See ckeditor/ckeditor5-theme-lark#119.
Reinmar referenced this issue in ckeditor/ckeditor5-theme-lark Feb 6, 2018
Internal: Content styles should belong to the packages that create the content. Closes #119.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-theme-lark Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants