-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content styles should not be in the theme and should not depend on variables #3387
Comments
I remember that we also discussed how to separate content styles and UI styles. Because if we moved the image, code, etc. styles to their respective packages, still they will be tied to the editor (e.g. loaded by some
I'm wondering how to do that and if webpack can help us. What we could possibly do is another entry point JS which would load content styles only using the style-loader. Could that work? OTOH, that would require another |
This is a separate issue. The ability to retrieve all content styles from the editor still requires these styles to be defined in the right place and to be independent of the theme. So, let's first fix the problem with where these styles are and how they look (which we can do pretty quickly). And then we can start thinking whether we are able to expose content styles in any way (which will be rather hard and we may end up writing them down in the docs manually). |
BTW, widget styles (focus outline, selection border) are not content styles to me. They are part of the editor's UI. |
Internal: Added content styles (moved from the theme package were they landed by mistake). See ckeditor/ckeditor5-theme-lark#119.
Internal: Added content styles (moved from the theme package were they landed by mistake). See ckeditor/ckeditor5-theme-lark#119.
Internal: Added content styles (moved from the theme package were they landed by mistake). See ckeditor/ckeditor5-theme-lark#119.
Internal: Added content styles (moved from the theme package were they landed by mistake). See ckeditor/ckeditor5-theme-lark#119.
Internal: Content styles should belong to the packages that create the content. Closes #119.
Examples:
<code>
stylesThese should be in their respective packages and should not depend on CSS variables.
The text was updated successfully, but these errors were encountered: