Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Fixed Shift + click selection of the table cells. #314

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tableselection.js
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export default class TableSelection extends Plugin {
return;
}

const anchorCell = getTableCellsContainingSelection( editor.model.document.selection )[ 0 ];
const anchorCell = this.getAnchorCell() || getTableCellsContainingSelection( editor.model.document.selection )[ 0 ];

if ( !anchorCell ) {
return;
Expand Down
33 changes: 33 additions & 0 deletions tests/tableselection.js
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,39 @@ describe( 'table selection', () => {
expect( preventDefault.called ).to.equal( true );
} );

it( 'should use the anchor cell from the selection if possible', () => {
const preventDefault = sinon.spy();

const domEventDataMock = new DomEventData( view, {
shiftKey: true,
target: view.domConverter.mapViewToDom(
// figure > table > tbody > tr > td
viewDocument.getRoot().getChild( 0 ).getChild( 1 ).getChild( 0 ).getChild( 0 ).getChild( 2 )
),
preventDefault
} );

tableSelection.setCellSelection(
modelRoot.getNodeByPath( [ 0, 1, 0 ] ),
modelRoot.getNodeByPath( [ 0, 2, 1 ] )
);
assertSelectedCells( model, [
[ 0, 0, 0 ],
[ 1, 1, 0 ],
[ 1, 1, 0 ]
] );

viewDocument.fire( 'mousedown', domEventDataMock );

assertSelectedCells( model, [
[ 1, 1, 1 ],
[ 1, 1, 1 ],
[ 0, 0, 0 ]
] );

expect( preventDefault.called ).to.equal( true );
} );

it( 'should ignore `selectionChange` event when selecting cells', () => {
const consoleLog = sinon.stub( console, 'log' );
const preventDefault = sinon.spy();
Expand Down