This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
I/6346: TableSelection should work with external changes. #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Type: Message. Closes ckeditor/ckeditor5#6346.
Additional information
Work in progress - based on I/6119: Clear table contents on clipboard "cut" and keyboard delete #254 & I/6150: Make table cell properties UI aware of mult-cell selection. #253 PRs so it would need to be rebased once those two got merged.
First naive implmeentation is to "fix" TableSelection state when there's an external change detected (focused on undo case). In such state, there will be some table cells in the selection but internally it will be blank.
However this is somewhat in a contrary to
_clearSelectionOnExternalChange()method.