-
Notifications
You must be signed in to change notification settings - Fork 17
Improvements for integration with track changes #202
Conversation
…execute()` now can take `forceValue` parameter.
…returned `cellIndex` value for some cases when `includeSpanned` was `true`. Other refactor in code and docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not happy with the change of yielding spanned cells. We loose the information when using includeSpanned: true
that currently yielded value is spanned by other cell.
So the idea before inlcudeSpanned: true
was to yield every table cell location (not a table cell). So if table should be 3x3 cells and have some cells merged (spanned over others) then it would have for instance 6 child table cells instead of 9.
Iterating over table in normal mode would yield 6 values while using includeSpanned: true
should yield all 9 locations from which 3 would be not have a table cell but will be spanned by others.
It's not ideal API and probably confusing one. We can rename the options to make it clearer. Also I would keep the information about the "spanned" cell. Previously it was cell: undefiend
but we can make this explicit as isSpanned: true
or cell: undefined, spannedBy: cell
. There is a possibility that the logic of other command would simplify by that.
As far as I've checked if changing |
So let's do this - we shouldn't loose that information. Also update the commit message regarding this change. |
…rRowCommand#execute()` to use `#value` for simpler code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question we're OK.
Okay, I updated docs and fixed what we agreed on fixing. |
Waits for: ckeditor/ckeditor5-engine#1781. |
Suggested merge commit message (convention)
Feature:
TableWalker
will now returncell
value also for spanned cells when traversing a table withincludeSpanned
option set totrue
. Additionally,isSpanned
property was introduced in returned values.Internal: Improvements in table plugin allowing for integration with track changes.
BREAKING CHANGE:
TableWalker
will not returnundefined
ascell
value for spanned cells anymore. UseisSpanned
instead.Additional information
Requires ckeditor/ckeditor5-engine#1781