Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/ckeditor5/1620: Fix downcast conversion in data pipeline when converting single paragraph with attributes in table cell. #180

Merged
merged 2 commits into from
Apr 3, 2019
Merged

T/ckeditor5/1620: Fix downcast conversion in data pipeline when converting single paragraph with attributes in table cell. #180

merged 2 commits into from
Apr 3, 2019

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Apr 1, 2019 •
edited
Loading

Suggested merge commit message (convention)

Fix: Single paragraphs with attributes inside tableCell will be properly converted in data pipeline.. Closes ckeditor/ckeditor5#1620.

Additional information

  • It works but probably some refactor of those converters would be nice.

@jodator jodator requested review from Reinmar and Mgsy April 1, 2019 14:55
@jodator
Copy link
Contributor Author

jodator commented Apr 1, 2019

@Mgsy could you check this case?

Mgsy
Mgsy approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@Mgsy Mgsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Reinmar Reinmar merged commit 67ec89f into master Apr 3, 2019
@Reinmar Reinmar deleted the t/ckeditor5/1620 branch April 3, 2019 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mgsy Mgsy Mgsy approved these changes

@Reinmar Reinmar Awaiting requested review from Reinmar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jodator @Mgsy @Reinmar