T/719 Image could be resized in read-only mode #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comandeer
requested changes
Aug 21, 2017
plugins/image2/plugin.js
Outdated
| @@ -428,8 +428,10 @@ | |||
|
|
|||
| // Setup dynamic image resizing with mouse. | |||
| // Don't initialize resizer when dimensions are disallowed (http://dev.ckeditor.com/ticket/11004). | |||
| if ( editor.filter.checkFeature( this.features.dimension ) && editor.config.image2_disableResizer !== true ) | |||
| // Don't initialize resizer when config.readOnly is set to true (#719). | |||
| if ( editor.filter.checkFeature( this.features.dimension ) && editor.config.image2_disableResizer !== true && editor.config.readOnly != true ) { | |||
There was a problem hiding this comment.
What if the editor is in read-only mode because someone uses editor.setReadOnly method (before initializing widgets), not a configuration option?
Such possibility introduces even more problematic question: what if read-only mode would change during using an editor? I honestly don't know how to fix such issue in the current version of editor as we don't have something like "refresh" method for widgets, which can listen to any changes in the editor and react accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
Yes
This PR contains
What changes did you make?
A new condition has been added to prevent initializing resizer.
Closes #719