-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent inline hardcoding width property using autogrow plugin #4919
Conversation
Rebased on newest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! It looks like the bug was introduced by... me 😞 in #4393
Also, your fix seems to be valid for the previous issue 😓
I think it will be good to change our docs for resize
method since we can use type other than number or string - which is still valid usage of that method. Also, please look at my inline comments.
Thanks, @sculpt0r for the review. |
Rebase on newest major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
However, I have to remove the comment about the height parameter. When you try to pass null there - the editor editable area is simply collapsed. There is no additional conditions for height value ;)
What is the purpose of this pull request?
Bug fix.
Does your PR contain necessary tests?
All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Did you follow the CKEditor 4 code style guide?
Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
What changes did you make?
Editor container shouldn't impose fixed size with single direction resize, so I've pass
null
aswidth
parameter ineditor.resize()
method to prevent this.Which issues does your PR resolve?
Closes #4891.