Preserved ideographic space on paste #1805
Conversation
|
Sorry, I've removed the |
| @@ -0,0 +1,12 @@ | |||
|
|
|||
| <textarea style="height: 80px; width: 500px;"> | |||
| 全角スペースの削除が行われたり半角スペース変換が行われたりする | |||
There was a problem hiding this comment.
Please remove tabs and new lines at the beginning and the end. Because of these characters, pasted text seems suspicious (it's full of ) and makes testing harder.
| @@ -808,6 +808,27 @@ | |||
| } ); | |||
| }, | |||
|
|
|||
| // (#1321) | |||
| 'htmlified text unification 7 - IDEOGRAPHIC space': function() { | |||
There was a problem hiding this comment.
This test seems possible to be simplified. Cases between browsers are very similar.
tests/plugins/clipboard/paste.js
Outdated
| @@ -808,6 +808,27 @@ | |||
| } ); | |||
| }, | |||
|
|
|||
| // (#1321) | |||
| 'htmlified text unification 7 - IDEOGRAPHIC space': function() { | |||
| if ( CKEDITOR.env.gecko ) | |||
There was a problem hiding this comment.
Note that our styleguide requires curly braces for every if block, even if it contains only one statement.
tests/plugins/clipboard/paste.js
Outdated
| { type: 'text', dataValue: 'a\u3000a\u3000\u3000' }, | ||
| 'htmlified text - webkit' ); | ||
| else | ||
| assert.isTrue( true ); |
There was a problem hiding this comment.
Is this else really needed? Every supported browser should be caught by one of the previous ifs.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
I removed stripping ideographic space
\u3000when pasting. The issue exists on IE and Firefox but I didn't ignore this tests for other browsers. I think it's good to keep them not ignored so they will fail in the future (with invalid changes). So keep in mind that manual and unit tests could work on Chrome, Opera and Safari regardless of the changes.Closes #1321