Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: easy image caption is hidden after paste #1790

Merged
merged 6 commits into from
Mar 22, 2018
Merged

Fixed: easy image caption is hidden after paste #1790

merged 6 commits into from
Mar 22, 2018

Conversation

jacekbogdanski
Copy link
Member

@jacekbogdanski jacekbogdanski commented Mar 13, 2018

What is the purpose of this pull request?

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

Caption is refreshed only when empty and without placeholder. With this change caption is preserved on paste.

Based on #1793

Closes #1592

Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As #1793 was merged, please rebase this PR onto the latest major. Additionally some changes here seems to be duplicates of changes in #1793.

Please also update version tags.

Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Comandeer Comandeer merged commit 082befd into major Mar 22, 2018
@Comandeer Comandeer deleted the t/1592 branch March 22, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easy Image caption is not visible after paste
2 participants