Added possibility to call CKEDITOR.editor.addCommand with CKEDITOR.command instance as parameter
#1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comandeer
requested changes
Mar 15, 2018
core/editor.js
Outdated
| @@ -740,12 +740,14 @@ | |||
| * } | |||
| * } ); | |||
| * | |||
| * Since 4.10 this method accepts `CKEDITOR.command` instance as param. | |||
There was a problem hiding this comment.
"also accepts" IMO sounds more suitable.
tests/core/command/command.js
Outdated
| @@ -302,5 +302,30 @@ bender.test( { | |||
| editor._.elementsPath.onClick( 0 ); | |||
|
|
|||
| wait(); | |||
| }, | |||
|
|
|||
| 'test addCommand from command instance': function() { | |||
There was a problem hiding this comment.
It'd be good to add test using CKEDITOR.command subclass, just in case to test if inherited commands are treated the same.
|
Sorry, I've removed the |
engineering-this
force-pushed
the
t/1582
branch
from
5691840 to
d2eb529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
New Feature
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
I've added check if
CKEDITOR.editor.addComandhas command instance passed it will register this command in editor and return it instead of creating new one.Also added unit test to cover that case.
Closes #1582