Easy image upload refactoring #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base64 encoded images.
…omatically use the one from the config.
…anually better than default FileLoader type).
Now it can be configured using widgetDefinition.uploadUrl (on uploadeasyimage widget). So one can use simply `widgetDefinition` event on editor to customize the upload URL if there's a need to.
Comandeer
requested changes
Oct 24, 2017
| @@ -438,6 +430,30 @@ | |||
| } ); | |||
|
|
|||
| wait(); | |||
| }, | |||
|
|
|||
| 'test cloudservices URL can be customized': function( editor ) { | |||
There was a problem hiding this comment.
Not only URL can be customised, but also loader type and additional request parameters. It'd be nice to have also tests for these.
|
For reasons unknown to me firefox fires Without getting into details I have changed listener type to This test suite relies on Also I have added requested test cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Other, refactoring of other PR.
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
This PR adds some fixes to #1052, the general idea was to simplify it and extract cloud-service (backend) stuff to a separate plugin.
There were already quite a few changes, many of which has been already fixed in #1062 and #1066.
Summary for this PR:
uploadUrlis now optional, as the plugin uses CloudService loader which automatically picks up URL from the config.loadMethodis now changed to upload. Since you proposed a more modern approach with object URL - I think it's fine, however we need a followup ticket to keep track of data allocated with it. See TP#3131.fileUploadResponse,fileUploadRequestas they're no longer needed (fixed in Cloud Services file loader #1062, Allow to use custom fileLoader in uploadRepository.create and upload widget #1066).uploadeasyimagewidget uses widget definition at a time of paste event to avoid Upload widget paste listener ignores changes in the uploadWidgetDefinition #1068. Though still I'm not happy that it's a copy pasta of a listener fromimageuploadplugin, we need to combine it. See TP#3132.easyimageUploadUrl,easyimage_tokenhave been renamed tocloudServices_url,cloudServices_tokenrespectively.responseDatastructure in unit tests.There's one issue that latest FF is extremely unstable, that's something that we need to investigate in a followup ticket.
Once this is merged, I'll just give a final check to #1052 and that will be it in terms of uploading.