Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom tags starting with embed are removed even when added to ACF #988

Closed
jswiderski opened this issue Sep 29, 2017 · 0 comments
Closed
Assignees
Labels
status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@jswiderski
Copy link
Contributor

Are you reporting a feature request or a bug?

Bug

Check if the issue is already reported

Provide detailed reproduction steps (if any)

  1. Use below configuration:
CKEDITOR.dtd['embedded-expression'] = { '#' : 1, 'span' : 1, 'img' : 1 };
CKEDITOR.dtd.$inline['embedded-expression'] = 1;
CKEDITOR.dtd.body['embedded-expression'] = 1; 

var editor = CKEDITOR.replace( 'editor1', {
    extraAllowedContent : 'embedded-expression[*]{*}(*)'
});
  1. Load sample page in browser and paste the following HTML in source mode <embedded-expression data-test="test">test</embedded-expression>
  2. Switch to wysiwyg and back to source.

Expected result

Tags stays

Actual result

Tag gets removed.

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: N/A
  • Installed CKEditor plugins: N/A

It seems these lines are responsible for that result: https://github.com/ckeditor/ckeditor-dev/blob/a0dd80a/core/htmldataprocessor.js#L802-L806.

A simple workaround would be changing tag name so that it doesn't start with embed.

@jswiderski jswiderski added type:bug A bug. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. labels Sep 29, 2017
@mlewand mlewand added this to the Backlog milestone Oct 2, 2017
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Oct 3, 2017
engineering-this added a commit that referenced this issue Jul 23, 2018
engineering-this added a commit that referenced this issue Aug 21, 2018
jacekbogdanski pushed a commit that referenced this issue Aug 28, 2018
@mlewand mlewand modified the milestones: Backlog, 4.10.1 Aug 28, 2018
@mlewand mlewand changed the title Custom tags starting with embed are removed even when added to ACF. Custom tags starting with embed are removed even when added to ACF Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants