Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing [scope] attribute for table cells when changing their type #5084

Closed
Comandeer opened this issue Feb 11, 2022 · 1 comment · Fixed by #5296
Closed

Missing [scope] attribute for table cells when changing their type #5084

Comandeer opened this issue Feb 11, 2022 · 1 comment · Fixed by #5296
Assignees
@sculpt0r
Labels
accessibility Issue related to accessibility. plugin:table The plugin which probably causes the issue. plugin:tabletools The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
4.20.0

Comments

@Comandeer
Copy link
Member

Type of report

Feature request

Provide description of the new feature

  1. Open https://jsfiddle.net/Comandeer/obkd95u1/
  2. Right click in the any of table cells and choose "Cell → Cell Properties".
  3. Change "Cell Type" to "Header" and confirm the changes.

Cell is replaced with th element but this element lacks the [scope] attribute. I propose replacing the "Header" value in "Cell Type" with two other: "Column Header" and "Row Header". They should produce th elements with appropriate [scope] attributes.
@Comandeer Comandeer added type:feature A feature request. status:confirmed An issue confirmed by the development team. plugin:table The plugin which probably causes the issue. plugin:tabletools The plugin which probably causes the issue. accessibility Issue related to accessibility. size:S labels Feb 11, 2022
@Comandeer Comandeer mentioned this issue Feb 11, 2022
Closed
@jacekbogdanski jacekbogdanski changed the title Missing [scope] atttrubute for table cells when changing their type Missing [scope] attribute for table cells when changing their type Mar 9, 2022
@sculpt0r sculpt0r self-assigned this Jul 25, 2022
sculpt0r added a commit that referenced this issue Jul 25, 2022
@sculpt0r
Add automatic tests for #5084
fd85bcf
sculpt0r added a commit that referenced this issue Jul 25, 2022
@sculpt0r
Add manual test for #5084
2d53e39
sculpt0r added a commit that referenced this issue Jul 25, 2022
@sculpt0r
Add solution #5084
ece4f1b
@sculpt0r sculpt0r mentioned this issue Jul 27, 2022
Merged
3 tasks
sculpt0r added a commit that referenced this issue Aug 2, 2022
@sculpt0r
Add automatic tests for #5084
86f2d12
sculpt0r added a commit that referenced this issue Aug 2, 2022
@sculpt0r
Add manual test for #5084
b6ad977
sculpt0r added a commit that referenced this issue Aug 2, 2022
@sculpt0r
Add solution #5084
53ca50e
Comandeer pushed a commit that referenced this issue Aug 9, 2022
@sculpt0r @Comandeer
Add automatic tests for #5084
d1599f5
Comandeer pushed a commit that referenced this issue Aug 9, 2022
@sculpt0r @Comandeer
Add manual test for #5084
a6217e5
Comandeer pushed a commit that referenced this issue Aug 9, 2022
@sculpt0r @Comandeer
Add solution #5084
cc9de01
@CKEditorBot
Copy link
Collaborator

Closed in #5296

@CKEditorBot CKEditorBot added this to the 4.20.0 milestone Aug 9, 2022
@chrisrhymes chrisrhymes mentioned this issue Dec 18, 2023
Open
@bspeare bspeare mentioned this issue Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sculpt0r sculpt0r

Labels
accessibility Issue related to accessibility. plugin:table The plugin which probably causes the issue. plugin:tabletools The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
4.20.0
Development

Successfully merging a pull request may close this issue.

Add scope attribute to table header cells ckeditor/ckeditor4
4 participants
@Comandeer @sculpt0r @jacekbogdanski @CKEditorBot