Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show current color in the Color Dialog #2639

Closed
usmanlogin opened this issue Nov 30, 2018 · 3 comments · Fixed by #2934
Closed

Show current color in the Color Dialog #2639

usmanlogin opened this issue Nov 30, 2018 · 3 comments · Fixed by #2934
Assignees
Labels
plugin:colorbutton The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone

Comments

@usmanlogin
Copy link

usmanlogin commented Nov 30, 2018

Type of report

Feature request.

Provide description of the new feature

  1. Apply color to text from Color Dialog
  2. Re open the Color Dialog and already applied color is not set in hex code input box.

Expected result

Color Dialog should show the already applied color value in the hex code input box

Actual result

You can only apply the color to text but cannot retrieve the color value.

Other details

2018-11-30_17h49_36

  • Browser: CHROME
  • OS: WINDOWS
  • CKEditor version: latest
  • Installed CKEditor plugins: colorbutton

Edit:

Consider #2639 (comment)

@usmanlogin
Copy link
Author

Sir any solution on this ?

@usmanlogin usmanlogin changed the title Is there any way to set applied text color in Color Dialog Is there any way to get color code in Color Dialog ? Dec 5, 2018
@engineering-this engineering-this self-assigned this Dec 7, 2018
@engineering-this engineering-this changed the title Is there any way to get color code in Color Dialog ? Show current color in the Color Dialog ? Dec 7, 2018
@engineering-this engineering-this changed the title Show current color in the Color Dialog ? Show current color in the Color Dialog Dec 7, 2018
@engineering-this
Copy link
Contributor

engineering-this commented Dec 7, 2018

Hello,

I can confirm your issue as valid Feature Request, hence I'm changing type from bug to feature.

@engineering-this engineering-this added type:feature A feature request. status:confirmed An issue confirmed by the development team. labels Dec 7, 2018
@engineering-this
Copy link
Contributor

engineering-this commented Dec 7, 2018

When implementing this feature it would be nice to add a line of recently used custom colors in color button -> #1795

However it might be problematic to detect current color as there can be many colors in current selection. Actually feature from #1795 might without ability to detect current color might be good enough, as user could reuse same colors many times without even need to open color dialog.

@f1ames f1ames added target:major Any docs related issue that should be merged into a major branch. plugin:colorbutton The plugin which probably causes the issue. labels Mar 1, 2019
@Dumluregn Dumluregn self-assigned this Mar 1, 2019
@f1ames f1ames added this to the 4.12.0 milestone May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:colorbutton The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants