Skip to content

Commit

Permalink
Added changelog entry for #2923, updated tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
jacekbogdanski committed Mar 4, 2019
1 parent 9ae8f72 commit 7c06ee9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Fixed Issues:

* [#2672](https://github.com/ckeditor/ckeditor-dev/issues/2672): Fixed: When resizing [Enhanced Image](https://ckeditor.com/cke4/addon/image2) to minimum size with a resizer the image dialog doesn't show actual values.
* [#1478](https://github.com/ckeditor/ckeditor-dev/issues/1478): Fixed: Custom colors added to [Color Button](https://ckeditor.com/cke4/addon/colorbutton) via [`config.colorButton_colors`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_config.html#cfg-colorButton_colors) in form label/code don't work correctly.
* [#2923](https://github.com/ckeditor/ckeditor-dev/issues/2923): Fixed: CSS `windowtext` color is not correctly recognized by [`CKEDITOR.tools.style.parse`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_tools_style_parse.html) functions.

API Changes:

Expand Down
6 changes: 6 additions & 0 deletions tests/core/tools/style.js
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,12 @@
assertObject( { top: '3px', right: '0', bottom: '2', left: '0' }, CKEDITOR.tools.style.parse.margin( '3px 0 2' ) );
},


// (#2923)
'test recognize `windowtext` as a color': function() {
assertObject( { color: 'windowtext' }, CKEDITOR.tools.style.parse.background( 'windowtext' ) );
},

// (#1490)
'test style.parse.sideShorthand docs sample': function() {
assertObject( { top: 'solid', right: 'dotted', bottom: 'solid', left: 'dotted' }, CKEDITOR.tools.style.parse.sideShorthand( 'solid dotted' ) );
Expand Down

0 comments on commit 7c06ee9

Please sign in to comment.