refactor!: avoid theme conflicts #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reorganizes the hugo templates and css to avoid collision with files mounted by other themes (is that possible? I don't actually know). It also avoids the use of global markdown hooks (`_default/_markup`), to avoid messing with non-modern-hugo-resume pages.
cjshearer
added a commit
that referenced
this pull request
Jul 18, 2024
Because the exampleSite's vendored dependencies include the `modern-hugo-resume` module defined in the root of our repo, its hash would need to be changed every time we updated the module. This was likely the cause of the site failing to build/deploy from #52.
Merged
cjshearer
added a commit
that referenced
this pull request
Jul 18, 2024
Because the exampleSite's vendored dependencies include the `modern-hugo-resume` module defined in the root of our repo, its hash would need to be changed every time we updated the module. This was likely the cause of the site failing to build/deploy from #52.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reorganizes the hugo templates and css to avoid collision with files mounted by other themes (is that possible? I don't actually know). It also avoids the use of global markdown hooks (
_default/_markup), to avoid messing with non-modern-hugo-resume pages.