Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memberships endpoint #224

Merged
merged 4 commits into from
Nov 12, 2024
Merged

memberships endpoint #224

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbc5511
memberships endpoint
RealHarshThakur Nov 6, 2024
48ca306
fix dto objects
RealHarshThakur Nov 7, 2024
5caae03
fix dto object
RealHarshThakur Nov 7, 2024
9bbea68
add organisation_id in tests for accounts check
RealHarshThakur Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix dto object 
Signed-off-by: Harsh Thakur <[email protected]>
  • Loading branch information
@RealHarshThakur
RealHarshThakur committed Nov 7, 2024
commit 5caae0371d6144ac8a998264ad276f6c5f11288f
4 changes: 1 addition & 3 deletions fake_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,7 @@ func NewFakeClient() (*FakeClient, error) {

// ListMemberships implemented in a fake way for automated tests
func (c *FakeClient) ListMemberships() (*MembershipResponse, error) {
return &MembershipResponse{
Accounts: c.OrganisationAccounts,
}, nil
return &MembershipResponse{}, nil
}

// Ping implemented in a fake way for automated tests
Expand Down
4 changes: 2 additions & 2 deletions membership.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import (

// MembershipResponse is the response for the memberships of a user
type MembershipResponse struct {
Accounts []Account
Organisations []Organisation
Accounts []MembershipAccount
Organisations []MembershipOrganisation
}

// MembershipAccount is the DTO for an account.
Expand Down
Loading