Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ValueError for type of target in MLPClassifier #90

Merged
merged 3 commits into from
Mar 26, 2018
Merged

Fixed ValueError for type of target in MLPClassifier #90

merged 3 commits into from
Mar 26, 2018

Conversation

mheilman
Copy link
Contributor

@mheilman mheilman commented Mar 22, 2018 •
edited
Loading

A very minor thing: we were printing y instead of target_type when raising an exception about the type of y.

@mheilman
Copy link
Contributor Author

@beckermr or @waltaskew, have a moment for a (hopefully) quick code review?

beckermr
beckermr approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheilman mheilman merged commit 9cc572c into civisanalytics:master Mar 26, 2018
@mheilman mheilman deleted the type_error_fix branch March 26, 2018 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mheilman @beckermr