update TF version, remove py3.5 support #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheilman
force-pushed
the
update_tf_version
branch
3 times, most recently
from
7e1a312 to
910a06f
Compare
mheilman
force-pushed
the
update_tf_version
branch
from
910a06f to
c88c03b
Compare
mheilman
changed the title
mheilman
commented
Nov 20, 2020
| @@ -1,4 +1,4 @@ | |||
| numpy~=1.14 | |||
| scipy~=1.0 | |||
| scikit-learn>=0.19 | |||
| tensorflow>=1.15.2,<2 | |||
| scikit-learn>=0.20.0,<0.23.0 | |||
There was a problem hiding this comment.
Using 0.19.x and 0.23.x makes the tests fail. I'm not sure how we didn't catch the 0.19.x incompatibility earlier, but I'd guess that the tests have been running as 0.20+ for a while.
hinnefe2
reviewed
Dec 1, 2020
|
Ah, oops. I initially tried adding 3.8 support but ran into the problem that tensorflow 1.15.4 isn't available for python 3.8 (https://pypi.org/project/tensorflow/1.15.4/#files). I updated the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the minimum TF version, per GHSA-4g9f-63rx-5cw4.
It also removes Python 3.5 support and sets more specific scikit-learn version requirements to avoid test failures and incompatibilities.