Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tpw-hire banner styling.css #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dianamartin
Copy link
Contributor

Update CSS for Header Banner Image Styling

  • line 83 to line 141

@dianamartin dianamartin added CSS Modified CSS code Knack Any Knack related PR's labels Jan 31, 2025
@dianamartin dianamartin self-assigned this Jan 31, 2025
Copy link
Contributor

@susannegov susannegov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space in line 34, but shouldn't effect anything

@@ -30,4 +30,112 @@ tr {
left: 0;
z-index: 6; /* Increase z-index to be higher priority than the header(lower #) */
background-color: #f9f9f9;
}
/*****************/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like Susanne mentioned. Just extra spacing before the closing bracket on line 33 and extra spacing before the comment header on line 34. I'd also suggest adding a line in between to create some spacing between the sections.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be updated in TPW HiRE | Production CSS. Line 34 spacing is off a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Modified CSS code Knack Any Knack related PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants