-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Spring Boot 2.0 for the base build (JDK8) #80
Conversation
Because Spring Boot 2.0 does not support JDK11, we build the JDK11 and JDK12 builds against Spring Boot 2.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sure, you are right. We are using 5.0.8 in Citrus 2.8.0. An update to 5.1.10 is too greedy. 👍
The build for jdk 8 is currently broken. We've to investigate this first. |
I agree. I might have some time later today to look into this. |
Seems the issue has something to do with a bytebuddy incompatibility/dependency clash. |
now the matrix build errors as the spring versions change and therefore the byte buddy version that is compatible/required |
fixed by downgrading bytebuddy to the same version as used in spring-boot-starter-test. |
Should close this in favour of #82. |
Closing in favor of #82 |
I leave those PRs open in general, because they are flagged as merged automatically if the internal branch I've created is merged. I mean it makes no technical difference but merged PRs look way more friendly than closed ones. 😆 |
ye but I mean this one is kind of a "won't fix" because it is duplicated, right? just not that we forget about it ;) |
Because Spring Boot 2.0 does not support JDK11, we build the JDK11 and JDK12 builds against Spring Boot 2.1