Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Spring Boot 2.0 for the base build (JDK8) #80

Closed

Conversation

boskoop
Copy link
Contributor

@boskoop boskoop commented Nov 3, 2019

Because Spring Boot 2.0 does not support JDK11, we build the JDK11 and JDK12 builds against Spring Boot 2.1

boskoop and others added 2 commits November 3, 2019 17:27
Because Spring Boot 2.0 does not support JDK11, we build the JDK11 and JDK12 builds against Spring Boot 2.1
@boskoop
Copy link
Contributor Author

boskoop commented Nov 3, 2019

Hi @svettwer

In order to provide Spring 5.0.x compatibility to citrus 2.8.0, the JDK8 build could build against Spring Boot 2.0, while the JDK11+ builds use Spring Boot 2.1+. This should resolve #15

BR
-- Christian

Copy link
Contributor

@svettwer svettwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sure, you are right. We are using 5.0.8 in Citrus 2.8.0. An update to 5.1.10 is too greedy. 👍

@svettwer
Copy link
Contributor

svettwer commented Nov 3, 2019

The build for jdk 8 is currently broken. We've to investigate this first.

@boskoop
Copy link
Contributor Author

boskoop commented Nov 3, 2019

I agree. I might have some time later today to look into this.

@svettwer
Copy link
Contributor

svettwer commented Nov 3, 2019

Seems the issue has something to do with a bytebuddy incompatibility/dependency clash.

@svettwer
Copy link
Contributor

svettwer commented Nov 3, 2019

mockito/mockito#1606

@svettwer
Copy link
Contributor

svettwer commented Nov 3, 2019

@svettwer
Copy link
Contributor

svettwer commented Nov 3, 2019

now the matrix build errors as the spring versions change and therefore the byte buddy version that is compatible/required

@svettwer
Copy link
Contributor

svettwer commented Nov 3, 2019

fixed by downgrading bytebuddy to the same version as used in spring-boot-starter-test.

@bbortt
Copy link
Collaborator

bbortt commented Nov 4, 2019

Should close this in favour of #82.

@christophd
Copy link
Member

Closing in favor of #82

@christophd christophd closed this Nov 4, 2019
@svettwer
Copy link
Contributor

svettwer commented Nov 4, 2019

I leave those PRs open in general, because they are flagged as merged automatically if the internal branch I've created is merged. I mean it makes no technical difference but merged PRs look way more friendly than closed ones. 😆

@bbortt
Copy link
Collaborator

bbortt commented Nov 4, 2019

ye but I mean this one is kind of a "won't fix" because it is duplicated, right? just not that we forget about it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants