This repository was archived by the owner on Oct 24, 2023. It is now read-only.
adapted for Spree 2 #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spree::User undefined
coffee script & javascript runtime
however this throws (concurrency?) errors if run in the hook works running it after
all related broken tests now passing
commits are mixed: count on hand tests are passing, along with product factories fixed to use a shipping category allow backorder preference syntax fixed, but most tests are commented remaining errors are caused by spree routes not available in dummy app
removed dummier (which wasn't including Spree::Core::Engine.routes http://stackoverflow.com/questions/18994172/spree-routes-not-available-in-extensions-dummy-application using built-in rake test_app instead idem
nox really fixed in ruby, with integration tests passing it still needs some tweaking at the javascript level, though
upgraded factory girl now using spree testing support factories added missing css (empty)
mostly updating capybara syntax to css changed _option_value_fields override to deface because wasn't working on test
only one lacking requires to fix actual code
2 tests are failing now...
this fixes broken intengration tests, as they expected this behaviour querying because of no apparent easy way to override a factory
which suddenly stopped workinhg...
this was freaking feature 'Should show out of stock for appropriate variants'
with this, all tests and features are passing :)
explicit that we're using `rake test_app` rather than dummier also added myself to contributors
|
Hey @Numerico thanks for the PR!! I'll check it out tonight and merge it if all the tests are passing! 👍 |
|
all right, just FYI |
|
@Numerico Is this working? |
|
yeah, you should be able to run the tests with |
|
Awesome! Thank you. |
|
Is this going to become a 2-1-stable branch for use with Spree 2.1? |
|
Hopefully, shouldn't change much from 2.0.4 to 2.1, should it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I used your extension in a Spree 2.0.4 project so had to adapt it to work with it.
I would say the main changes were to move count_on_hand and backorderable from products and variants down to stock items.
I've got all tests passing and features green in this commit.
I would be available to discuss any comments if needed.
Thanks