Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sslyze to 1.4+ versions #159

Merged
merged 5 commits into from
Apr 3, 2018
Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Apr 3, 2018

No description provided.

@jsf9k jsf9k self-assigned this Apr 3, 2018
@jsf9k jsf9k requested review from konklone, IanLee1521 and dav3r April 3, 2018 18:37
@@ -3,7 +3,6 @@ language: python
sudo: false

python:
- '2.7'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the comment at nabla-c0d3/nassl#34 (comment) that justifies this, and 👍, but flagging this for watchers as a significant change -- this drops Python 2 support for pshtt entirely.

I think it would be worth (in a separate PR, which I can file) noting that this is a Python 3 only tool in the README.

@konklone konklone merged commit 2531a0f into develop Apr 3, 2018
@konklone konklone deleted the improvement/upgrade_sslyze branch April 3, 2018 19:16
cisagovbot pushed a commit that referenced this pull request Jul 30, 2024
…s/setup-python-5

Bump actions/setup-python from 4 to 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants