Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document option to use alias in artifact URLs #935

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Document option to use alias in artifact URLs #935

merged 2 commits into from
Nov 3, 2021

Conversation

fkorotkov
Copy link
Contributor

Fixes #931

@fkorotkov fkorotkov requested a review from edigaryev November 3, 2021 16:53
@fkorotkov fkorotkov enabled auto-merge (squash) November 3, 2021 16:53
edigaryev
edigaryev reviewed Nov 3, 2021
View reviewed changes
docs/guide/writing-tasks.md Outdated
```

It's also possible to download a particular file of an artifact and not the whole archive by using `<ARTIFACTS_NAME>/<PATH>`
instead of `<ARTIFACTS_NAME>.zip`.
It's also possible to download a particular file of an artifact and not the whole archive by using `<ARTIFACTS NAME>/<PATH>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're changing ARTIFACTS_NAME to ARTIFACTS NAME (why, btw), maybe change it everywhere then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, let's stick with ARTIFACTS_NAME. Fixed in 40c87af

@edigaryev edigaryev self-requested a review November 3, 2021 17:05
@fkorotkov fkorotkov merged commit e5d1bae into master Nov 3, 2021
@fkorotkov fkorotkov deleted the alias-in-artifacts branch November 3, 2021 17:07
@promag
Copy link

promag commented Nov 3, 2021

This is awesome, thanks!

hebasto added a commit to bitcoin-core/gui-qml that referenced this pull request Nov 5, 2021
@hebasto
Merge #79: ci: Set alias in tasks with artifacts in cirrus.yml
1480e50 
011fcff ci: Set alias in tasks with artifacts in cirrus.yml (João Barbosa)

Pull request description:

  This change simplifies artifact links by using the task alias. It also allows changing the task name without breaking artifact links.

  [![Windows](https://svgshare.com/i/ZhY.svg)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/79)
  [![macOS](https://svgshare.com/i/ZjP.svg)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/79)

ACKs for top commit:
  hebasto:
    ACK 011fcff, it is documented in Cirrus CI [now](cirruslabs/cirrus-ci-docs#935).

Tree-SHA512: b6bab010ad7adc14fad2eea0c08b22f09154fe1f5bb0e5055c2d55ddb9abb9b2cfbced8a64b38bbb302a609ddb9f8631353d25c761b9c7cdffdbc8da0de2ee8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edigaryev edigaryev edigaryev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support task alias in artifacts URLs
3 participants
@fkorotkov @promag @edigaryev