Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERVER-1793] - Expanding Reality Check #53

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

circlery
Copy link
Contributor

@circlery circlery commented Aug 4, 2022

Summary

Expands reality check by adding in a third required environment variable CIRCLE_CLOUD_PROVIDER which runs android machine jobs in GCP, and ARM machine jobs in AWS environments.

Other Changes

  • Rewrites readme
  • Adds a screenshot of a successful run in a GCP environment

Updating Existing Reality Checks

The new AWS and GCP workflows will fail in existing reality check installations until the CIRCLE_CLOUD_PROVIDER project environment variable is set; this is indicated in the job failure message.

@circlery circlery self-assigned this Aug 4, 2022
@circlery circlery requested a review from a team August 4, 2022 20:31
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Co-authored-by: Atul Singh <[email protected]>
@soulchips
Copy link
Contributor

@circlery this is gonna fail till you add the variable to the project in cloud. You may need to speak with RE on this
cc/ @yugesh84

@yugesh84
Copy link

@circlery this is gonna fail till you add the variable to the project in cloud. You may need to speak with RE on this cc/ @yugesh84

So, we don't directly use this realitycheck in any of our pipelines. We use a GHE flavor in all of our CI, and for the k9s job, a fork of this repo.
There should be a separate card (if you want this in CI) so RE can work with y'all to propagate these changes everywhere.

Also, as this is used for 2.x installs also, these new jobs might break for customers that try to run this in 2.x. Is this something that is a concern to us? Maybe not, but just want to ensure that it's been discussed.

@circlery circlery requested a review from jbialy August 15, 2022 17:21
README.md Outdated Show resolved Hide resolved
Co-authored-by: Atul Singh <[email protected]>
@circlery circlery requested a review from atulsingh0 August 15, 2022 18:31
@circlery
Copy link
Contributor Author

Created a tag for anyone who may be using 2.x/3.x and hasn't yet forked this repository.
https://github.com/circleci/realitycheck/releases/tag/server-2-3

Will merge for all 4.x installations.

@circlery circlery merged commit 9058f9b into master Aug 17, 2022
@circlery circlery deleted the server-1793-expand-reality-check branch August 17, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants