Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent workdir permissions #72

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Parent workdir permissions #72

merged 1 commit into from
Mar 31, 2022

Conversation

LegenJCdary
Copy link
Collaborator

fixing issue #69

@LegenJCdary LegenJCdary force-pushed the parent_workdir_perms branch 3 times, most recently from 1070a56 to 47245a5 Compare March 30, 2022 14:55
@LegenJCdary LegenJCdary requested a review from cinek810 March 30, 2022 14:57
Copy link
Owner

@cinek810 cinek810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge after changes

@@ -5,3 +5,6 @@ global_paths:
file_naming:
log_file_name_frmt: "ansible-deploy_execution_{}.log"
sequence_prefix: "SEQ"

permissions:
parent_workdir: 17407
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it has to be configurable, but it's fine to have it.
As before.. never use decimental for permissions - 0o177

@@ -41,3 +41,12 @@ check_message_not_in_output() {
fi
}

check_permissions() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check_file_permissions?

@LegenJCdary LegenJCdary force-pushed the parent_workdir_perms branch 2 times, most recently from 5216e98 to fa14d04 Compare March 31, 2022 07:39
Add tests for permissions and new function in test lib
@LegenJCdary LegenJCdary force-pushed the parent_workdir_perms branch from fa14d04 to 3300c6d Compare March 31, 2022 07:43
@LegenJCdary LegenJCdary merged commit deb3dd0 into main Mar 31, 2022
@LegenJCdary LegenJCdary deleted the parent_workdir_perms branch March 31, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants