Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Db record parsing fixes #168

Merged
merged 12 commits into from
Feb 17, 2023
Merged

Db record parsing fixes #168

merged 12 commits into from
Feb 17, 2023

Conversation

LegenJCdary
Copy link
Collaborator

bugfix 75cf653

@LegenJCdary LegenJCdary changed the title Db record parsing fix for ansible-core 2.11.8 Db record parsing fix Feb 13, 2023
@LegenJCdary LegenJCdary marked this pull request as draft February 14, 2023 08:46
@LegenJCdary
Change error message detection string ("err" to "error") in Formatter…
4ae5f8f 
…s.format_ansible_output

Bugfix a2c68e1
@LegenJCdary
Return formatted ansible output as dict from Formatters.format_ansibl…
2cadae6 
…e_output

Collect all std messages (without warnings)
@LegenJCdary
Add exception logging in DbWriter.parse_yaml_output()
1d3068d 
Remove staticmethod decorator
@LegenJCdary
Make start-of-task detection stricter in DbWriter.parse_yaml_output
9193bb4 
Bugfix 75cf653
@LegenJCdary
Collect task to yaml parser correctly when more than 1 host in inventory
a14774f 
Add find_end_of_task static method to DbWriter class
Bugfix 75cf653
@LegenJCdary
Improve task_name grab in DbWriter.parse_yaml_output
0b0ad2a 
Bugfix 75cf653
@LegenJCdary
Add "task_details" column to table "play_item_tasks" in database.schema
d1b3b78 
Remove unnecessary "play_item_tasks" columns
@LegenJCdary LegenJCdary marked this pull request as ready for review February 15, 2023 09:45
@LegenJCdary LegenJCdary self-assigned this Feb 15, 2023
@LegenJCdary LegenJCdary requested a review from cinek810 February 15, 2023 10:16
@LegenJCdary LegenJCdary changed the title Db record parsing fix Db record parsing fixes Feb 15, 2023
@LegenJCdary LegenJCdary mentioned this pull request Feb 15, 2023
Merged
cinek810
cinek810 reviewed Feb 17, 2023
View reviewed changes
source/modules/database/schema.py Outdated
"task": "varchar",
"start": "datetime",
"end": "datetime",
"host_locked": "boolean",
Copy link
Owner

@cinek810 cinek810 Feb 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sqlite doesn't know boolean, maybe we should call it int?

2.1. Boolean Datatype
SQLite does not have a separate Boolean storage class. Instead, Boolean values are stored as integers 0 (false) and 1 (true).

SQLite recognizes the keywords "TRUE" and "FALSE", as of version 3.23.0 (2018-04-02) but those keywords are really just alternative spellings for the integer literals 1 and 0 respectively.

cinek810
cinek810 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Owner

@cinek810 cinek810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bools/text are minor comment. I don't see any need to work on that more. Having in mind that we're likely to change approach to callback plugin

@LegenJCdary LegenJCdary merged commit 49925d2 into main Feb 17, 2023
@LegenJCdary LegenJCdary deleted the correct_db_main branch February 17, 2023 08:11
@LegenJCdary LegenJCdary mentioned this pull request Feb 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cinek810 cinek810 cinek810 approved these changes

Assignees

@LegenJCdary LegenJCdary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LegenJCdary @cinek810