Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] stabilize tabs indexing issue #56

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

eakarr
Copy link
Contributor

@eakarr eakarr commented Oct 24, 2024

I added initialIndexRef to stabilize tabs indexing issues on react strict mode. Tabs component was working completely fine on production but it was twice indexing on development mode. Right now, it has been stabilized for all modes.

First of all:
  • Choose a name suits for the implementation
  • Prefix your pull request name with [feat], [fix], [refactor], [ci], [chore], [docs], [test], [style], [refactor], [perf], [build] or [revert]
  • Add description about the pull request
  • Add or edit tests and make sure it covers all the implementation
  • Add or edit Storybook
  • Includes a link to issue if exists
  • Check for Accessibility Pratices w3
What this pull request does?
  • Creates a new package
  • Fixes a bug in an existing package
  • Refactors an existing package
  • Updates typescript definations
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other
When creating a new package:
  • Follows same structure with other packages
  • Passes all Accessibility Practices
  • Base styles in a style.css file at the root of src folder if needed

Emir Akar added 2 commits October 24, 2024 13:55
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
 - @ciceksepeti/[email protected]
@eakarr eakarr merged commit 096662f into main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants