Fixes usage of aria-owns/controls in trigger #633
Conversation
|
Is this for standalone use of the dropdown or for it's use within ember-power-select? If it's for the latter, I just released today 5.0.0 of ember-power-select with improved a11y, which may fix your problems. |
|
This is intended for standalone use of the dropdown. Those recent changes to In our case, I could forcibly set |
|
Sidenote: what's up with the CI failures? Seems like it's having trouble loading the tests at all? The suite seemed to run without error locally, but if I've messed something up that's breaking CI, I'll figure it out. |
|
I'm woring on a fix on #634 |
|
CI should be better now |
matthew-robertson
force-pushed
the
master
branch
from
8e89b6a to
3235ba0
Compare
Closes cibernox#557. This mostly just fixes the merge conflicts present in cibernox#558. To re-iterate, this commit uses `aria-controls` instead of `aria-owns` to build the relationship between the trigger and its content. In addition, the `aria-owns` property is migrated to the trigger's parent. This fixes an issue I ran into using Apple's VoiceOver software, in which I couldn't use the movement commands (VO+right-arrow) to navigate into dropdown menus created with ember-basic-dropdown.
matthew-robertson
force-pushed
the
master
branch
from
3235ba0 to
9573527
Compare
|
Seems like the CI's passing, and I've fixed the merge conflicts I encountered. Lemme know if there's anything else I can fix up with it. |
|
I missed your last push. CI is running, I'll merge when it's done. |
|
Merged! Thanks! I’ll release a new version in a couple days. Ping me if you see I don’t by Friday. |
ghost
mentioned this pull request
Closes #557.
This mostly just fixes the merge conflicts present in #558.
To re-iterate, this commit uses
aria-controlsinstead ofaria-ownsto build the relationship between the trigger and its content. In addition, thearia-ownsproperty is migrated to the trigger's parent.This fixes an issue I ran into using Apple's VoiceOver software, in which I couldn't use the movement commands (VO+right-arrow) to navigate into dropdown menus created with ember-basic-dropdown.