Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mirakcのapi/statusとの互換性をもたせる #52

Closed
ci7lus opened this issue May 20, 2022 · 2 comments · Fixed by #53
Closed

mirakcのapi/statusとの互換性をもたせる #52

ci7lus opened this issue May 20, 2022 · 2 comments · Fixed by #53
Assignees
@ci7lus
Labels
enhancement New feature or request
Milestone
v2

Comments

@ci7lus
Copy link
Owner

ci7lus commented May 20, 2022

@humiaozuzu:
@ci7lus Currently Mirakc do not implement /api/status API (will return an empty object) and this change will break Mirakc support For Mirakc api docs: https://github.com/mirakc/mirakc/blob/main/docs/web-api.md#apistatus
f2139cf#commitcomment-74042074
@ci7lus ci7lus added the enhancement New feature or request label May 20, 2022
@ci7lus ci7lus added this to the v2 milestone May 20, 2022
@ci7lus ci7lus self-assigned this May 20, 2022
ci7lus added a commit that referenced this issue May 20, 2022
@ci7lus
👽️ mirakcのstatusするように (#52)
41e667b
@ci7lus
Copy link
Owner Author

ci7lus commented May 20, 2022 •
edited
Loading

@humiaozuzu Will this build work with mirakc? https://github.com/ci7lus/MirakTest/actions/runs/2356161514

ci7lus added a commit that referenced this issue May 20, 2022
@ci7lus
👽️ mirakcのstatusとの互換性をもたせる (#52)
20b7ce9
@humiaozuzu
Copy link

It's working now.

Thank you for making such a great app.

@ci7lus ci7lus mentioned this issue May 22, 2022
Merged
ci7lus added a commit that referenced this issue May 22, 2022
@ci7lus
Merge pull request #53 from ci7lus/fix/mirakc-status-support
1c66c10 
👽️ mirakcのstatusとの互換性をもたせる (#52)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ci7lus ci7lus

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

👽️ mirakcのstatusとの互換性をもたせる (#52) ci7lus/MirakTest
2 participants
@humiaozuzu @ci7lus