fix(core): Assigns an overriden name to constructor named constructor

Fixes: angular#10545
chuckjaz · Aug 24, 2016 · 9b5534a · 9b5534a
1 parent 14a30f3
commit 9b5534a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/modules/@angular/core/src/util/decorators.ts b/modules/@angular/core/src/util/decorators.ts
@@ -243,7 +243,8 @@ export function Class(clsDef: ClassDefinition): Type<any> {
     Reflect.defineMetadata('annotations', this.annotations, constructor);
   }
 
-  if (!constructor['name']) {
+  const constructorName = constructor['name'];
+  if (!constructorName || constructorName === 'constructor') {
     (constructor as any)['overriddenName'] = `class${_nextClassId++}`;
   }
 

diff --git a/modules/@angular/core/test/util/decorators_spec.ts b/modules/@angular/core/test/util/decorators_spec.ts
@@ -132,6 +132,10 @@ export function main() {
               .toThrowError(
                   'Class definition \'extends\' property must be a constructor function was: non_type');
         });
+
+        it('should assign an overridden name for annonymous constructor functions', () => {
+          expect((Class({constructor: function() {}}) as any).overriddenName).not.toBeUndefined();
+        });
       });
     });
   });