Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl FromStr for Locale #11

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Impl FromStr for Locale #11

merged 5 commits into from
Dec 13, 2023

Conversation

cecton
Copy link
Collaborator

@cecton cecton commented Dec 13, 2023

Fixes #9

@cecton cecton requested review from djc and pitdicker December 13, 2023 10:48
@gibbz00
Copy link

gibbz00 commented Dec 13, 2023

Awesome 😊 maybe squash the commits?

@cecton
Copy link
Collaborator Author

cecton commented Dec 13, 2023

Awesome 😊 maybe squash the commits?

nahhh I love my commit messages to feel very natural

@cecton cecton merged commit 5ed4b00 into main Dec 13, 2023
2 checks passed
@cecton cecton deleted the impl-from-str branch December 13, 2023 13:42
@cecton
Copy link
Collaborator Author

cecton commented Dec 13, 2023

usually they go like "clippy", "WIP", "clippy omg please", "damn you clippy", ... :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@pitdicker pitdicker Awaiting requested review from pitdicker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement FromStr for locale.
3 participants
@cecton @gibbz00 @djc