Fixes for Duration::new

[pitdicker]

Thanks to @Skgland in #1337 (comment) for noticing.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b92b736) 91.84% compared to head (67277eb) 91.84%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1405   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files          38       38           
  Lines       17518    17518           
=======================================
  Hits        16090    16090           
  Misses       1428     1428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[djc]

If we're going to make this public, should we instead do a div_mod for nanos and add the modulo to the seconds?

[pitdicker]

If we're going to make this public, should we instead do a div_mod for nanos and add the modulo to the seconds?

I like that it now is just the most basic way to set the fields of a Duration.

std::time::Duration::new does carry over nanoseconds beyond 1.000.000.000 to seconds. That adds another case that makes it fallible:

Panics

This constructor will panic if the carry from the nanoseconds overflows the seconds counter.