-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Weekday::days_since
.
#1249
Add Weekday::days_since
.
#1249
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 37 37
Lines 18148 18151 +3
=======================================
+ Hits 16661 16664 +3
Misses 1487 1487 ☔ View full report in Codecov by Sentry. |
Hmm, it must be late 😆. I'll fix it to actually work, and merge it with the not-public |
1b0831a
to
1091e16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just squash these commits and make sure that days_since()
lives underneath the existing methods?
(You can keep the original author around with an Co-authored-by:
tag in the commit message.)
'Co-authored-by:` is new for me, I'll have to learn about that. |
Co-authored-by: Paul Dicker <[email protected]>
Thank you! It doesn't render special in Git Gui, but I guess this is it... |
This resurrects the work in #216 by @clarfonthey.
WeekDay::days_since
doesn't offer any new functionality, but I quite like its API.Fixes #201, #1560.