Add FromStr for FixedOffset #1092
Conversation
| @@ -991,6 +992,15 @@ impl FromStr for Weekday { | |||
| } | |||
| } | |||
|
|
|||
| /// Parsing a `str` into a `FixedOffset` uses the format [`%z`](./format/strftime/index.html). | |||
There was a problem hiding this comment.
| /// Parsing a `str` into a `FixedOffset` uses the format [`%z`](./format/strftime/index.html). | |
| /// Parsing a `str` into a `FixedOffset` uses the format [`%z`](crate::format::strftime). |
Should take care of the CI warning.
There was a problem hiding this comment.
Please move this impl below the FixedOffset definition.
There was a problem hiding this comment.
This addition should be move to src/offset/fixed.rs.
| @@ -221,7 +221,7 @@ pub(super) fn trim1(s: &str) -> &str { | |||
|
|
|||
| /// Consumes one colon char `:` if it is at the front of `s`. | |||
| /// Always returns `Ok(s)`. | |||
| pub(super) fn consume_colon_maybe(mut s: &str) -> ParseResult<&str> { | |||
| pub(crate) fn consume_colon_maybe(mut s: &str) -> ParseResult<&str> { | |||
There was a problem hiding this comment.
These two methods don't need to be public for the crate.
But maybe you should keep them like this, and put the FromStr implementation in offset/fixed.rs. It seems to be an exception to put them in this file.
| @@ -991,6 +992,15 @@ impl FromStr for Weekday { | |||
| } | |||
| } | |||
|
|
|||
| /// Parsing a `str` into a `FixedOffset` uses the format [`%z`](./format/strftime/index.html). | |||
There was a problem hiding this comment.
Please move this impl below the FixedOffset definition.
| @@ -991,6 +992,15 @@ impl FromStr for Weekday { | |||
| } | |||
| } | |||
|
|
|||
| /// Parsing a `str` into a `FixedOffset` uses the format [`%z`](./format/strftime/index.html). | |||
There was a problem hiding this comment.
This addition should be move to src/offset/fixed.rs.
| Self::east_opt(offset).ok_or(OUT_OF_RANGE) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This addition should be move to src/offset/fixed.rs.
|
Merged in #1157. Thank you for working on this. |
Closes #314