-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Picture in picture does not render the video controls overlay when hovering on the video #3482
Comments
This also reproduces on Windows 10 with current master (M113). Mouseover of the PiP window shows cursor changes and clicking the link works as expected, so this is likely a rendering issue. Does not reproduce when using |
Looks like this broke in M101/M102 (working in 100, partially broken in 101 (red text/button regions), fully broken in 102 (red content area)) |
Looks like ColorProvider in video_overlay_window_views.cc is returning solid red (kPlaceholderColor) instead of the expected theme color kColorPipWindowControlsBackground which has an alpha component. |
Alloy needs to initialize the Chrome color mixer as shown in https://chromium.googlesource.com/chromium/src/+/e959940a7e4830a492dac6a5a6e9f143970e40f6%5E%21/#F1 |
Initialize the Chrome color mixer so that ColorProvider returns the expected semi-transparent color for overlay background in video_overlay_window_views.cc instead of the default opaque red color (kPlaceholderColor).
Initialize the Chrome color mixer so that ColorProvider returns the expected semi-transparent color for overlay background in video_overlay_window_views.cc instead of the default opaque red color (kPlaceholderColor).
Describe the bug
When playing video in picture-in-picture the playback works as expected, however when hovering on the window, CEF is not able to render the usual overlay containing the native controls, and instead renders the fallback red tile. This happens when running in the client sample app of CEF but not in similar versions of chrome.
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour

The native video element controls should appear on hover
Screenshots


Playback:
OnHover:
Versions (please complete the following information):
Additional context
Does the problem reproduce with Google Chrome at the same version?
No
The text was updated successfully, but these errors were encountered: