windows: dbghelp.dll from Windows SDK causes local CEF builds to hang

[magreenblatt]

Original report by me.

---

When a local Windows build of CEF crashes or asserts the application hangs for an extended period of time (minutes) and memory continues to increase. In some cases the 32-bit process will run out of memory and be terminated by the OS.

This appears to be a problem with the dbghelp.dll version 10.0.20348.1 from the recent Windows SDK update.
Downgrading dbghelp.dll to version 10.1.10150.0 (included with the VS2019 install) fixes the issue (stack traces are now almost instantaneous again).

We should copy dbghelp.dll/dbgcore.dll from the VS install instead of the Windows SDK for local CEF builds.

Related Chromium issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1320818

[magreenblatt]

Copying from the VS install won’t be sufficient, since that only contains x86 binaries (not x64 or arm64).

[magreenblatt]

Looks like the best option (currently) is to not copy these DLLs to the out directly at all, but instead implicitly use the version from system PATH (e.g. “C:\Windows\System32”). This is currently 10.0.19041.867 with Windows 10 Version 10.0.19044, and seems to work fine.

[magreenblatt]

Don't copy dbghelp.dll/dbgcore.dll from the Windows SDK (fixes issue #3356)

→ <<cset 71ef10bb604d (bb)>>

[magreenblatt]

• changed state from "new" to "resolved"

[magreenblatt]

Don't copy dbghelp.dll/dbgcore.dll from the Windows SDK (fixes issue #3356)

→ <<cset ca90a945ccde (bb)>>

[magreenblatt]

We should revisit this now that Chromium has updated to Win11 SDK 10.0.22621.0 in M112+

[magreenblatt]

• changed state from "resolved" to "open"

[magreenblatt]

It’s still version 10.0.20348.1 in the “C:\Program Files (x86)\Windows Kits\10\Debuggers\x64” directory. There is also a DbgHelp.dll (but no dbgcore.dll) version 10.0.22621.755 in the “C:\Program Files (x86)\Windows Kits\10\App Certification Kit” directory. These binaries are both 64-bit.

VS2022 includes 32-bit, 64-bit and ARM64 builds of dbghelp.dll (but no dbgcore.dll) version 10.0.22551.1001 in the “C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\IDE\Extensions\TestPlatform\Extensions\Cpp“ directory.

[magreenblatt]

Version 10.0.22551.1001 included with VS2022 seems to work fine (tested with M112).

[magreenblatt]

After installing “Debugging tools for Windows” for the Win SDK (optional component) I now have version 10.0.22621.755, which works. We can now return to the default behavior of copying dbghelp.dll/dbgcore.dll from the SDK.

[magreenblatt]

win: Copy dbghelp.dll/dbgcore.dll from the Windows SDK (fixes issue #3356)

→ <<cset 3e4f8d1b9ccf (bb)>>

[magreenblatt]

• changed state from "open" to "resolved"