-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP/2 support #57
Comments
(Copying my observation from the Chromium bug.) I can perform the scan just fine from the Google corporate network. It's exactly the same Go code as on hstspreload.appspot.com I'll talk to the Cloud team. |
For reference, the Chromium bug initially filed for this was https://crbug.com/637610 |
I was contacted about this again today. That makes three reports within 4 days, with no previous issues. |
It happens for my domains now too after enabling http/2 on my frontends. |
Could you post which domain that is? |
You can test using Thanks for looking into it! |
Another case: |
A lot of these have come up very recently. We should fix this soon. |
Thanks Lucas. Once again thanks for your effort in this Lucas! |
The following appears in the logs a lot: |
Some more stuff:
I'm currently working on trying to move hosting to a full VM. |
Oh, and Go 1.7 for App Engine/Flexible Environment is under way, but not launching soon enough. |
#35 will eventually remove the site if we don't support HTTP/2 in the scanner. |
Note that the scanner supports HTTP/2 if you use the proper version of Go. |
@lgarron what can we do about that? |
From some looking around, it looks like App Engine / Flexible Environment might support Go 1.7 in beta soon (like, very soon). Barring that, I could use help figuring out a way to adapt https://github.com/chromium/hstspreload to use HTTP/2 in 1.6 (which I've seen indications is possible, but haven't had time to do). |
I'm not sure if you need more test cases but I have a number of domains this affects. biopsychiatry.com I've preloaded mdma.net and hedweb.com prior to moving to HTTP/2 and they are still preloaded at the moment. All of the above sites are on the same server and get the same results on the SSL Labs test. |
This gives us flexibility to swap out the hosting to address issues like #57. appspot.com subdomains are restricted to App Engine / Flexible Environment, but this way we can switch to using VMs.
After a month of trying to track down this planned change, it appears that this won't be happening. :-/ |
Hi - It's working fine with HTTP2 URLs now! Thanks! |
Are you sure? |
Also, someone reported |
I'm not 100% sure, but please see (but not submit) this: This site is using h2, but hstspreload shows me the form to add. |
Hmm, interesting. Sounds like some HTTP/2 sites work, and some don't. If someone knows a lot about HTTP/2, I could use some help sleuthing to figure out what's different about |
There is a very good chance I'm at wrong here, but I tested the failed domain names ( Here is a comparison for your reference: https://gist.github.com/Ayesh/be83385f63699f2946d29bce5cdce7bc I also tested with For rs-devdemo.host (which did pass the test), I'm using |
Hmm, |
|
It seems I've sent Brad Fitzpatrick an email about this, and have sent questions |
I'm having the same problem (SSL Labs rates me A+). -> % nginx -v I'm using certs from Letsencrypt. Anything else you want to know? |
What's your domain? Also, any chance you can get it to pass |
I'll see about h2spec this evening (about 4 hours from now for me). |
Another data point: I was able to submit But either something else was broken then, or the test changed — that domain redirects to HTTPS only if the request includes Today, when I submit the domain, it gets rejected because of a missing redirect. If you didn't change anything, then it working temporarily could be evidence of other mysterious/wrong App Engine behavior. But no more certificate chain gripes. |
I tried working around this in a few ways:
I might have tried setting In any case, I'm running out of ideas short of moving to a custom VM. For the people on this thread with sites that still fail, could you let me know what stack your server is running? |
h2spec for my domain: So some fail, most go well. Full log: http://pastebin.com/cYvN4eXb For my stack, see above. Here is my nginx-config: http://pastebin.com/FTMqJ4nT |
@theromi for comparison, here is the results of a site that is passing the hstspreload test as well (it's from https://http2.pro).
FWIW, above server is running Apache 2.4.25, with ECDSA (prime256v1) + RSA (2048 bits) dual certificates. It produces same results over RSA 2048 as well. For me, the hstspreload test started to pass only after I upgraded Apache from 2.4.23 to 2.4.25. This upgrade contained some HTTP2 security fixes. Unless the hsts check had any changes, upgrading to 2.4.25 will most likely fix the h2spec test. No clue about nginx. |
Looks like we're now on Go 1.8; yay! All the examples in this bug seem to work now. If anyone is still seeing issues with HTTP/2, please file a new bug. |
Unfortunately, my domain (romanmichel.de) still does not work. |
Same here, czc.cz returns Invalid certificate chain. |
|
I'm running into what I think is the same error with my own website - evaryont.me (running nginx on Centos 7) @lgarron do you have a recommended client to test Go & HTTP/2? Would httpstat suffice? |
I checked locally, and evaryont.me does not have the same error. However, it seems your headers are malformed. Try removing the second colon after
|
Submitting a website which supports HTTP/2 fails with "Error: Invalid Certificate Chain".
The message advises running the SSL Labs test, which passes.
It sounds like other folks have experienced the same issue with HTTP/2 sites.
The text was updated successfully, but these errors were encountered: