-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add toast type attribute support with IDL property and default styles
This change adds the toast type attribute and property according to the PR on the toast explainer here: jackbsteinberg/std-toast#49 There is still work TODO on implementing this PR, w.r.t the showToast type option, a11y behavior for warning / error, and default features for those types (Infinity duration, closebutton, etc) Additionally, a follow-up CL will come out to reconfigure the current reflection tests for type and open to use established reflection test methodology (ex: https://cs.chromium.org/chromium/src/third_party/blink/web_tests/wpt_internal/std-switch/tentative/form-associated-basic.js) Bug: 972945 Change-Id: I58c7079dc4f748928eea44103dece835e549986e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708313 Commit-Queue: Jack Steinberg <[email protected]> Reviewed-by: Fergal Daly <[email protected]> Cr-Commit-Position: refs/heads/master@{#680073}
- Loading branch information
Jack Steinberg
authored and
Commit Bot
committed
Jul 23, 2019
1 parent
95dfe56
commit 79d4c9b
Showing
3 changed files
with
111 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters