Avoid invalid ::part selector
#113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ghengeveld Assuming this gets merged, I have at least one other change to submit afterwards. |
Do you want to release that other change along with this one? In that case this PR should be labeled with |
I assumed it would be easier to just release once, which is why I gave that heads-up. I don't have permissions to modify the labels on the PR, so I guess you will need to add the label (unless you want to give contributors that permission). |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not valid CSS to add a class selector to the
::part()pseudo-element, so rewriting a selector like::part(foo):hoverto::part(foo).pseudo-hoveris a problem.::-webkit-scrollbar-thumband::-webkit-slider-thumbhave the same limitation, and there was already logic to avoid generating modified selectors that included those. However, that logic was overly restrictive, preventing valid rewrites likediv:hover::-webkit-scrollbar-thumb->div.pseudo-hover::webkit-scrollbar-thumb.This change includes:
::part()followed by a class selectorelt:hover::part(foo)andelt:hover::-webkit-scrollbar-thumbpseudo-*-allclasses get added to shadow hosts, even if their shadow DOM didn't have stylesheets that got rewritten. This is necessary to support::part()-based styling, since those styles are (usually) in the light DOM.pseudo-*-allclasses get cleared from shadow hosts when switching Storybook stories::part()support