Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI & TurboSnap docs to reflect we now trace dependencies #193

Merged

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Dec 18, 2022

Merge after we ship Enhanced TurboSnap.

@linear
Copy link

linear bot commented Dec 18, 2022

AP-2273 Finer-grained full rebuilds from lockfiles

Currently when using TurboSnap, a change to a package.json or yarn.lock/package-lock.json/etc results in a full retest of all stories in a project. However, in a monorepo setup, there may be multiple packages, each with their own package.json . If an unrelated package (e.g. a server-only package) adds/removes/updates a dependency, it would cause a retest of all projects in the monorepo. This can be gotten around by using the --untraced flag (like --untraced \"./packages/!(foo)/**\" to only retest when files in the foo package change), but it's not ideal to have to specify these. Furthermore, it means that non-dependency changes to a package.json file (like adding an NPM script) automatically trigger retests, though the file changes may be unrelated to any components.

Instead, we could look within the package manager's lockfile to see what dependencies changed, and if any of those are imported by components in a given package, we'd mark those components recursively as needing to be retested. See additional details here.

@netlify
Copy link

netlify bot commented Dec 18, 2022

👷 Deploy request for chromatic-docs pending review.

A Netlify team Owner will need to approve the deploy before you can run your build.

Are you a team Owner? Visit the deploys page to approve it

Need more help? Learn more in the Netlify docs

Name Link
🔨 Latest commit 2848ead

@jonniebigodes
Copy link
Contributor

Thanks for this @ghengeveld. I'll take a deeper look tomorrow morning my time and if nothing requires changes, I'll merge it.

@jonniebigodes
Copy link
Contributor

With the latest commit, I polished up the document for clarity and some minor grammar issues spread across the document. Merging this

@jonniebigodes jonniebigodes merged commit 3b90eeb into main Dec 19, 2022
@jonniebigodes jonniebigodes deleted the ghengeveld/ap-2273-finer-grained-full-rebuilds-from branch December 19, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants