-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Storybook published messaging #920
Conversation
903f977
to
7890caa
Compare
@tevanoff Can I reference the Canary build and then what? |
@ethriel3695 I added some info about testing to the PR message. Those two flags seemed to affect the behavior of the output in my testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tevanoff I think this did it!
I ran the Action with the latest and saw the undefined stories
output.
Now on the canary:
Collecting Storybook metadata
Collected Storybook metadata
→ ; no supported addons found
Initializing build
Initialized build
→ Build 17 initialized
Publish your built Storybook
→ Validating Storybook files
Publishing your built Storybook
→ Calculating file hashes
Publishing your built Storybook
→ Starting publish
→ [ ] 0%
Publish complete in 9 seconds
→ Uploaded 168 files (28.73 MB)
Verifying your Storybook
→ This may take a few minutes
→ [* ]
⚠ TurboSnap not available for your account
To ensure your project is fully setup and baselines are properly established,
TurboSnap is not available until at least 10 builds are created from CI and one
of those builds is accepted.
ℹ Review your TurboSnap availability on the Manage screen:
https://www.chromatic.com/manage?appId=65bdd147c425b429f5968c04
✔ Storybook published
We found 14 components with [23](https://github.com/enhanced-dev/blog-tutorial-remix/actions/runs/7880523801/job/21502694657#step:6:24) stories.
ℹ View your Storybook at https://65bdd147c4[25](https://github.com/enhanced-dev/blog-tutorial-remix/actions/runs/7880523801/job/21502694657#step:6:26)b4[29](https://github.com/enhanced-dev/blog-tutorial-remix/actions/runs/7880523801/job/21502694657#step:6:30)f5968c04-bqslfbpzzu.chromatic.com/
![Screenshot 2024-02-12 at 6 45 21 PM](https://private-user-images.githubusercontent.com/12070791/304271756-cb972c19-1e8b-429a-8209-469605dfc484.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NjU2MTgsIm5iZiI6MTczODk2NTMxOCwicGF0aCI6Ii8xMjA3MDc5MS8zMDQyNzE3NTYtY2I5NzJjMTktMWU4Yi00MjlhLTgyMDktNDY5NjA1ZGZjNDg0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDIxNTUxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZkNTM4ZTZhODIwODkyNmE3ZTM4YjgwM2Y5MjdiMzZmYWJiMzgwYWY4ZDM1Y2UwNzFhN2I3NTkzNDQ0MmE0N2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.2tIiORnOpEHvDWZThLfoVojlrrRtzUo0jCsmP7-P0T4)
It looks like this is what we want.
if (build) { | ||
// `ctx.build` is initialized and overwritten in many ways, which means that | ||
// this can be any kind of build without component and stories information, | ||
// like PASSED builds, for example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why PASSED
builds would not have component and story information. They were tested after all.
🚀 PR was released in |
This fixes a couple of issues with the Storybook published messaging.
publishBuild
step meant that sometimes thectx.build
used to construct the message was in an early stage (likePASSED
) without component and story information, resulting in a message like:verifyBuild
step under certain conditions (like withexit-once-uploaded
), resulting in duplicate messaging like:How to Test
exit-once-uploaded
andonly-changed
.📦 Published PR as canary version:
10.9.6--canary.920.7904727338.0
✨ Test out this PR locally via: